adoptium / adoptium/infrastructure

Ansible request for CentOS6_Cent7SSL role to follow best practises

Open
#2,373 0 comments 0 reactions 1 assignee Claimed by @Willsparker View on GitHub
ansible
Dominant language
Python
Stars
96
Forks
106
Avg merge
1d 23h
Merged PRs (30d)
13

Description

- [ ] Missing install
- [x] Bug in ansible playbook
- [ ] Request for new playbook addition

Details:
With the VPC bug on C6 fixed with #2372, I noticed that the role isn't really [idempotent](https://docs.ansible.com/ansible/latest/reference_appendices/glossary.html#term-Idempotency) as, if it fails halfway through, it can cause earlier tasks to fail. Certainly the `rpm` command I used in #2372 will fail if it tries to install the `openssl` packages when they've been installed before. Currently the role serves it's purpose, but I'd like to clear it up a bit (assuming I can and it doesn't NEED the hacks, because CentOS6 - which it may do).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.