adoptium / adoptium/aqa-tests

Missing `def` keyword in groovy

Open
#6,065 11 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
155
Forks
346
Avg merge
2d 9h
Merged PRs (30d)
36

Description

Noticed the following warning messages in the [Jenkins job](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder_JCK/3864/console).

```
Did you forget the `def` keyword? WorkflowScript seems to be setting a field named SPEC (to a value of type String) which could lead to memory leaks or other issues.
Did you forget the `def` keyword? WorkflowScript seems to be setting a field named dockerAgents (to a value of type ArrayList) which could lead to memory leaks or other issues.
Did you forget the `def` keyword? WorkflowScript seems to be setting a field named dockerAgentLabel (to a value of type String) which could lead to memory leaks or other issues.
Did you forget the `def` keyword? WorkflowScript seems to be setting a field named LABEL (to a value of type String) which could lead to memory leaks or other issues.
Did you forget the `def` keyword? WorkflowScript seems to be setting a field named LABEL (to a value of type String) which could lead to memory leaks or other issues.
...
Did you forget the `def` keyword? WorkflowScript seems to be setting a field named dynamicAgents (to a value of type ArrayList) which could lead to memory leaks or other issues.
```

Contributor guide

Open the contributing guide

Research direction

The linked Jenkins job console is the starting entry point; search the aqa-tests Groovy pipeline for assignments to SPEC, dockerAgents, dockerAgentLabel, LABEL, and dynamicAgents. Confirm the relevant assignments no longer produce the reported warnings in that job's console.

Written by the indexing model from the issue text.

Assessment

Tech stack
groovy
Domain
ci-cd, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.