add logic for jdk-version specific suites
- Dominant language
- HTML
- Stars
- 155
- Forks
- 346
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 36
Description
https://github.com/adoptium/aqa-tests/pull/5553#issuecomment-2340815163 have reminded me old issue, where some external tests, eg jacoco, works fine with 8-17 but do not work with jdk21
Unluckily, current logic to clone and checkout is in https://github.com/adoptium/aqa-tests/blob/master/external/jacoco/test.properties
So I see several options with many pros and cons:
- narrow the checkout in test.sh ( I do not like this)
- have duplicated testfolder (so jacoco target would be limited for jdk21 onwards, and will have updated tag, and new jacoco17 wold be limited to 17 and older)
- create flexible checkout logic in properties file similar to what I did for os-based properties (I'm not sure I like this)
- tag_version -> tag(7|8)_version and tag(21|22)_version ....
- this is less expendable to other non-external test
This will be quite a precedent for other - at least external - tests
Many others maybe have to be simply disabled for older/newer jdks, but that is easily done in playlists?
* have playlist's `` per set of jdks.
Contributor guide
Research direction
Start by reading external/jacoco/test.properties and test.sh, then inspect playlist handling for JDK-specific selection. The issue needs a decided approach for version-specific checkout or playlist logic; done means the chosen design supports the Jacoco JDK ranges and establishes a pattern for other external tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, shell
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100