adoptium / adoptium/aqa-tests

Update executeCmdWithRetry() to do with rt_code=128

Open
#4,323 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
155
Forks
346
Avg merge
2d 9h
Merged PRs (30d)
36

Description

[executeCmdWithRetry() in get.sh ](https://github.com/adoptium/aqa-tests/blob/master/get.sh#L468) is used to retry git if there are unexpected failures.

Running in mac locally found if the return code is 128, which says the folder exist and not empty, executeCmdWithRetry will continue to retry instead of either delete the dir or exit the command.

Contributor guide

Open the contributing guide

Research direction

Start in get.sh around executeCmdWithRetry() at line 468 and inspect how git failures and return code 128 are handled. Reproduce the macOS case if possible, then confirm the intended completed behavior for a non-empty directory: remove it before retrying or stop with the command's failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, shell
Domain
testing-qa, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.