Update third party applications information setting
- Dominant language
- HTML
- Stars
- 155
- Forks
- 346
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 36
Description
In external tests, each third party application has its own test.properties file, which is used to set up docker environments with all necessary tools installed.
Right now some properties are set by other property, which causes duplication and make the parsing logic complex.
For example, `debianslim_packages` and `ubuntu_packages` are set by `debian_packages`
```
debian_packages="git maven"
debianslim_packages="${debian_packages}"
ubuntu_packages="${debian_packages}"
```
https://github.com/adoptium/aqa-tests/blob/master/external/camel/test.properties#L7-L9
Parsing logic like:
```
debian_packages=$(getProperty "debian_packages")
debian_packages=`echo "$debian_packages" | awk -F'"' '{print $2}'`
debianslim_packages=${debian_packages}
ubuntu_packages=${debian_packages}
```
https://github.com/adoptium/aqa-tests/blob/master/external/common_functions.sh#L222-L225
We'd like to do some cleanup and enhancement to simply the setting process.
1. https://github.com/adoptium/aqa-tests/issues/2962
2. https://github.com/adoptium/aqa-tests/issues/2964
3. https://github.com/adoptium/aqa-tests/issues/2966
4. To set_test_info() we can also run command source path/test.properties, which is another option.
Contributor guide
Research direction
Start with external/camel/test.properties and external/common_functions.sh, especially the property parsing around lines 222-225 and the set_test_info() entry point. Review the related issues 2962, 2964, and 2966 before choosing an approach. Done means third-party application properties no longer rely on duplicated derived assignments and the setting process remains functional.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100