adoptium / adoptium/TKG

openj9 nightly from artifactory openjdk tests is mistakenly running against extra eclipse ( eclispe adoptium) problemlist

Open
#656 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
22
Forks
114
Avg merge
4d 2h
Merged PRs (30d)
8

Description

Grinder https://ci.adoptium.net/view/Test_grinder/job/Grinder/12189/console

```
15:22:53 -exclude:"/home/jenkins/workspace/Grinder/aqa-tests/TKG/../openjdk/openjdk-jdk/test/jdk/ProblemList.txt" \
15:22:53 -exclude:"/home/jenkins/workspace/Grinder/aqa-tests/TKG/../../jvmtest/openjdk/excludes/ProblemList_openjdk17-openj9.txt" \
15:22:53 \
15:22:53 -exclude:"/home/jenkins/workspace/Grinder/aqa-tests/TKG/../openjdk/excludes/vendors/eclipse/ProblemList_openjdk17.txt" \
15:22:53 "/home/jenkins/workspace/Grinder/aqa-tests/TKG/../openjdk/openjdk-jdk/test/jdk:jdk_nio"; \
```

https://github.com/adoptium/TKG/blob/master/src/org/openj9/envInfo/JavaInfo.java#L173-L174 set vendor=eclispe for both java.vendor=Eclispe Adoptium(temurin) and java.vendor=Eclispe Openj9 (openj9). aqa-tests/openjdk use vendor=eclipse https://github.com/adoptium/aqa-tests/tree/master/openjdk/excludes/vendors/eclipse https://github.com/adoptium/aqa-tests/blob/master/openjdk/openjdk.mk#L244 for adoptium specific issues.

java.vendor=Eclispe Adoptium(temurin) and java.vendor=Eclispe Openj9 (openj9) need to be differentiated.

Possible solutions is redefining vendor value for example:
java.vendor=Eclispe Adoptium(temurin) --> adoptium, or temurin, or eclipseadoptium
java.vendor=Eclispe Openj9 (openj9) --> openj9, or eclispeopenj9 or ibm ( if using ibm, openj9 and semu can still be differentiated by impl)

The vendor value redefinition might affect playlist.xml. If playlist.xml is using eclipse it might need to update.

Contributor guide

Open the contributing guide

Research direction

Start with src/org/openj9/envInfo/JavaInfo.java at lines 173-174 and reproduce the Grinder 12189 command to confirm how both vendors select the eclipse problem list. Then inspect openjdk/openjdk.mk at line 244 and the referenced vendor-specific ProblemList files. Done means Adoptium and OpenJ9 vendor values select distinct problem lists, with playlist.xml updated if it depends on the current eclipse value.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.