adoptium / adoptium/TKG

SysinternalsSuite.zip should be download via getDependencies.pl

Open
#559 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
22
Forks
114
Avg merge
4d 2h
Merged PRs (30d)
8

Description

Noticed in the [job console](https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/40912/consoleFull) that SysinternalsSuite.zip is downloaded at the runtimes and moved into `testDependency\system_lib\windows_sysinternals`. This is NOT due to this PR as SysinternalsSuite.zip is not even in the `systemtest.getDependency` job. However, we should handle this as well. I will open a separate issue for this.

```
00:08:47.503 configure-windows-sysinternals:
00:08:47.503 [echo] Executing macro download-file
00:08:47.503 [echo] File to download: https://download.sysinternals.com/files/SysinternalsSuite.zip
00:08:47.503 [echo] Destination: C:\temp\/windows_sysinternals/SysinternalsSuite.zip
00:08:47.503 [echo] Download tool: curl
00:08:47.503 [mkdir] Created dir: C:\temp\windows_sysinternals
00:08:47.503 [exec] % Total % Received % Xferd Average Speed Time Time Time Current
00:08:47.503 [exec] Dload Upload Total Spent Left Speed
00:08:47.503 [exec]
00:08:48.583 [exec] 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 95 50.7M 95 48.5M 0 0 38.7M 0 0:00:01 0:00:01 --:--:-- 39.0M100 50.7M 100 50.7M 0 0 39.3M 0 0:00:01 0:00:01 --:--:-- 39.6M
00:08:48.583 [unzip] Expanding: C:\temp\windows_sysinternals\SysinternalsSuite.zip into C:\Users\jenkins\testDependency\system_lib\windows_sysinternals
00:09:12.595 [delete] Deleting directory C:\temp\windows_sysinternals
```

_Originally posted by @llxia in https://github.com/adoptium/TKG/issues/533#issuecomment-2138056174_

Contributor guide

Open the contributing guide

Research direction

Start with getDependencies.pl and the configure-windows-sysinternals job entry point shown in the console log. Trace how SysinternalsSuite.zip is currently downloaded and unpacked, then verify that the dependency script handles it instead of the runtime job; done means the runtime no longer performs that download and move.

Written by the indexing model from the issue text.

Assessment

Tech stack
perl
Domain
devops
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.