Remove unnecessary macros
- Dominant language
- Java
- Stars
- 22
- Forks
- 114
- Avg merge
- 4d 2h
- Merged PRs (30d)
- 8
Description
Due to historical reasons, we have `D`, `SQ`, and `Q` macros defined in makefile in TKG and used in test repos.
For example:
https://github.com/AdoptOpenJDK/TKG/blob/master/compile.mk#L17
https://github.com/AdoptOpenJDK/TKG/blob/master/makeGen.mk#L26
https://github.com/AdoptOpenJDK/TKG/blob/master/makeGen.mk#L28
It will be more clear and simple if these values can be explicitly written in makefile and test files. For example,
- we do not need to modify the value when copying from the playlist for running system_custom
- [macro is not defined issue](https://github.com/AdoptOpenJDK/TKG/pull/157) will not happen
I think we should verify and remove the macros from makefiles and test repos if they are unnecessary.
Contributor guide
Assessment
This issue has not been assessed yet.