adoptium / adoptium/TKG

KEEP_REPORTDIR does not work as expected

Open
#156 5 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
22
Forks
114
Avg merge
4d 2h
Merged PRs (30d)
8

Description

When KEEP_REPORTDIR is set to false, we should not capture any passed test artifacts. However, this does not work as expected. Please see the build link below:
https://ci.eclipse.org/openj9/job/Test_openjdk8_j9_extended.functional_s390x_linux_aot_Personal_testList_0/4/

It looks like all test artifacts are captured.

I think this is due to test pipeline uses boolean https://github.com/AdoptOpenJDK/openjdk-tests/blob/e55242930ee3bd56ceb2cbdcb898df130fbfc9c9/buildenv/jenkins/JenkinsfileBase#L78
https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/buildenv/jenkins/JenkinsfileBase#L264

and TKG uses string https://github.com/AdoptOpenJDK/TKG/blob/b7d19e42ab2c131d71ba037304b6efd8e07d5ad5/settings.mk#L195

Contributor guide

Open the contributing guide

Research direction

Start with the KEEP_REPORTDIR handling at buildenv/jenkins/JenkinsfileBase lines 78 and 264, then compare it with TKG's settings.mk line 195. Use the linked CI build as the failing example and verify that setting KEEP_REPORTDIR to false does not capture passed-test artifacts while the enabled behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
groovy
Domain
ci-cd, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.