adopted-ember-addons / adopted-ember-addons/validated-changeset

Object.keys(property) returns an empty array on an object property that has not been mutated

Open
#191 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
38
Forks
27
PR merge metrics
No merged PRs in 30d

Description

Given this code

```
let objectToWrap = {
objectProperty: {
foo: 'bar',
},
};

let changeset = Changeset(objectToWrap);

let keys = Object.keys(changeset.objectProperty);
```

I would expect `keys` to be `['foo']` but it returns an empty array.

I believe the issue lies here: https://github.com/validated-changeset/validated-changeset/blob/c1c95b729aae80fd30b30b691202a94c974a3309/src/utils/object-tree-node.ts#L56

It always returns `ownKeys` from `node.changes` even if no changes have been made.

I have created a repro here, but it's just the code above https://github.com/elgordino/validated-changeset-repro

I've raised a PR with tests. Not sure if the overall approach is the best way forward, but it works :)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.