adopted-ember-addons / adopted-ember-addons/validated-changeset

Snapshot changes is wrong when object has proxy attributes

Aberta
#102 6 comentários 0 reações 0 responsáveis Ver no GitHub
bug
Linguagem predominante
TypeScript
Estrelas
38
Forks
27
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

Hi, changeset of ED Models with async belongsTo relationships show incorrect changes on snapshot:
![Screenshot 2021-02-03 at 16 15 37](https://user-images.githubusercontent.com/50884/106775512-1799ef80-663b-11eb-8145-fa68de987259.png)

`change` and `changes` are correct, but `snapshot().changes` shows all my async belongsTo as changed attributes incorrectly.

I think this is because of this unrwrap https://github.com/validated-changeset/validated-changeset/blob/da68651a41028ab827872cf10960920779c2a09f/src/index.ts#L975

Which adds all the unwrapped relationships to `this[CHANGES]`. When i get `change` and `changes` these incorrect changes are filtered out, but not on snapshot.

Does my explanation make sense? Thanks in advance!

EDIT:
If anyone else comes here looking for a solution I'm currently creating snapshots like this until it is fixed
```js
function createSnapshot(cs) {
const changes = {};
cs.changes.forEach(({ key, value }) => { changes[key] = value; });
return {
changes,
errors: { ...cs.error },
};
}
```

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.