adopted-ember-addons / adopted-ember-addons/ember-sortable

modifiers: dimension are calculated incorrectly if they vary between elements

Ouverte
#350 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
good first issue
Langage dominant
TypeScript
Étoiles
299
Forks
159
Merge moyen
4 j 6 h
PR mergées (30 j)
4

Description

**Describe the bug**
If the sortable elements have different margins, ember-sortable calculates the height of the elements incorrectly, which collapses all margins.

**To Reproduce**
Use the following css to apply margins to sortable elements
`li + li { margin-top: 20px; }`

**Expected behavior**
Existing margins should not collapse.

**Additional context**
This issue has been noticed using the modifiers version of the add-on.
I tried to find a quick fix, however there seem to more issues within calculating the height of the element. For instance only marginBottom is applied, but no marginTop. Adding marginTop fixed some issue, but introduced new ones, so there probably is another bug with calculating the position correctly.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.