adopted-ember-addons / adopted-ember-addons/ember-router-helpers

`url-for` does not match rfc design for query-params

Open
#292 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
38
Forks
16
PR merge metrics
No merged PRs in 30d

Description

it expects query-params to be a param instead of a named argument

Implementation: https://github.com/rwjblue/ember-router-helpers/blob/be355137b4ae957934831c4be11bad3a9d848fdb/addon/helpers/url-for.js#L9

RFC: https://emberjs.github.io/rfcs/0391-router-helpers.html#url-for-helper

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.