adopted-ember-addons / adopted-ember-addons/ember-pikaday
Improve `minDate` and `maxDate` parsing
未关闭
bug
- 主要语言
- JavaScript
- 星标
- 156
- 派生
- 164
- PR 合并指标
- 30 天内没有已合并 PR
描述
Currently, it seems like `minDate` and `maxDate` both _must_ be `Date` objects, otherwise things blow up, because `getTime` is called on whatever is passed in
https://github.com/adopted-ember-addons/ember-pikaday/blob/4097041f439832102fb09840757ec85a10fb1b40/addon/mixins/pikaday.js#L146
https://github.com/adopted-ember-addons/ember-pikaday/blob/4097041f439832102fb09840757ec85a10fb1b40/addon/mixins/pikaday.js#L171
I think that, in both cases, the object should first be converted to a `Date` (or `moment` object?`) and then the time extracted.
贡献指南
评估
这个 Issue 还没有评估数据。