adopted-ember-addons / adopted-ember-addons/ember-paper

Tab Component lacks accessible role="tab"

Open
#1,169 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
879
Forks
327
PR merge metrics
No merged PRs in 30d

Description

The [ember-paper Tabs](https://miguelcobain.github.io/ember-paper/#/components/tabs) component renders a wrapper element with a `role='tablist`, which is a superb start. However, an element with this role _requires_ a child element to have a `role='tab'` https://dequeuniversity.com/rules/axe/3.5/aria-required-children?application=axeAPI.

Running a `a11yAudit` with popular [`ember-a11y-testing` addon](https://github.com/ember-a11y/ember-a11y-testing) fails with a `aria-required-children` rule violation.

![Screenshot_2020-10-15_14-42-20](https://user-images.githubusercontent.com/1664093/96178972-c9c77300-0ef5-11eb-80a1-e4cfa43f4317.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.