adopted-ember-addons / adopted-ember-addons/ember-moment
Is ember-cli-moment-shim still required for ember-moment?
- Lingua principale
- JavaScript
- Stelle
- 398
- Fork
- 120
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Hi! Thanks for taking care of this addon!
I wonder whether the https://github.com/jasonmit/ember-cli-moment-shim is still required for ember-moment?
In case it DOES NOT, should we remove the [blueprint](https://github.com/adopted-ember-addons/ember-moment/blob/8297380f25fec796efc09fc50f715fb7687cd08d/blueprints/ember-moment/index.js#L12-L15)?
In case it DOES, should we update ember-cli-moment-shim to the latest v3.8.0 in the [blueprint](https://github.com/adopted-ember-addons/ember-moment/blob/8297380f25fec796efc09fc50f715fb7687cd08d/blueprints/ember-moment/index.js#L12-L15)?
ember-cli-moment-shim v3.4.0 is a blocker for upgrading to the latest ember versions since it relies on `ember-cli-babel@6.6.0`.
ATM I upgraded to the latest ember-moment v9.0.1, removed ember-cli-moment-shim, and don't see any downsides so far.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.