adopted-ember-addons / adopted-ember-addons/ember-metrics
Allow configuration of name of Mixpanel page viewed event
- Langage dominant
- TypeScript
- Étoiles
- 367
- Forks
- 158
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Instead of [hardcoding the event name `page viewed`](https://github.com/poteto/ember-metrics/blob/8e5ac364e23129ac69e4dfa6c05d3167ff4dabf7/addon/metrics-adapters/mixpanel.js#L65), allow this to be configurable via the ember-metrics configuration object.
example implementation:
```javascript
trackPage(options = {}) {
const config = get(this, 'config');
let { trackPageEventName } = config;
trackPageEventName = trackPageEventName || 'page viewed';
const event = { event: trackPageEventName };
const mergedOptions = assign(event, options);
this.trackEvent(mergedOptions);
},
```
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.