adopted-ember-addons / adopted-ember-addons/ember-local-storage

Most test fails when updating from 2.0.6 to 2.0.7

Open
#379 5 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
220
Forks
78
PR merge metrics
No merged PRs in 30d

Description

Error: Assertion Failed: Cannot create a new tag for `<(unknown):ember922>` after it has been destroyed.

test:
```js
import { module, test } from 'qunit';
import { setupTest } from 'ember-qunit';
import StorageObject from 'ember-local-storage/local/object';
import resetStorages from 'ember-local-storage/test-support/reset-storage';

module('Unit | Services | UserOptionsDestroyer', function (hooks) {
setupTest(hooks);

module('upon a successful user options object destruction', function (hooks) {
hooks.beforeEach(function () {
const mockStorage = StorageObject.extend();

mockStorage.reopenClass({
initialState() {
return {
userId: '1',
};
},
});

this.owner.register('storage:userOptions', mockStorage);
});

hooks.afterEach(function () {
window.localStorage.clear();
resetStorages();
});

test('should return a positive response', async function (assert) {
assert.expect(1);

const service = this.owner.lookup('service:destroyers/user-options-destroyer');

const response = await service.destroyOptions();

const expectedServiceResponse = { success: true, result: null };

assert.deepEqual(response, expectedServiceResponse);
});
});
});
```

Related to https://github.com/funkensturm/ember-local-storage/pull/377

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.