adopted-ember-addons / adopted-ember-addons/ember-light-table

table height attribute warning is annoying

Abierto
#502 5 comentarios 0 reacciones 0 asignados Ver en GitHub
foreign-addon help wanted
Lenguaje dominante
JavaScript
Estrellas
311
Forks
130
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

#449 made it optional to specify a table height attribute, which is great for those of us sizing the table with CSS. However, when I'm doing this intentionally, I don't want to see these warnings.

Can we add an option or setting that will silence these, probably on a per-table basis? That way I could provide an attribute like `requireHeight: false` to each table where I'm explicitly choosing not to set the height because I know CSS has it taken care of.

I think this should be pretty simple so I'm happy to put together a PR if that sounds appropriate :v:

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.