adopted-ember-addons / adopted-ember-addons/ember-light-table
Number.isNaN and Number.parseInt breaks app in IE
Ouverte
good first issue
help wanted
- Langage dominant
- JavaScript
- Étoiles
- 311
- Forks
- 130
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Hi,
I don't think you should use Number.isNaN and Number.parseInt in the lt-body component:
https://github.com/offirgolan/ember-light-table/blob/master/addon/components/lt-body.js
as it breaks apps in IE. I've tested IE 11.
I think you should use a polyfill or isNaN, and parseInt directly.
Thanks,
Camille
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.