adopted-ember-addons / adopted-ember-addons/ember-infinity

Move to Immutable Arrays

Aperta
#151 2 commenti 2 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
374
Fork
128
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

A concern I have is that Ember Infinity heavily relies on "pushing objects" into arrays. I don't think this is a great approach - as it relies on Ember's pushObjects API staying consistent - the `_internalModel` stuff is confusing for folks.

Instead I think we should be creating new arrays based on the existing & new data.

@davidgoli also raised some concern about using the store's `query` object in ember infinity. I agree. David - can you share some of your thoughts here?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.