adopted-ember-addons / adopted-ember-addons/ember-cp-validations

`ember-data` v5.3.4+ compatibility

Open
#758 3 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
439
Forks
172
PR merge metrics
No merged PRs in 30d

Description

I just updated an app that is using ember-cp-validations to the Ember v5.12 blueprint (coming from v4.12). After the update a runtime error is thrown:

```
Could not find module `ember-data` imported from `(require)` missingModule`.
```
Which is imported here:
https://github.com/adopted-ember-addons/ember-cp-validations/blob/13d8f8457ac9a50370050205bff189f20f526e01/addon/utils/utils.js#L14-L16

I believe this is caused by the fact that `ember-data` [v5.3.4+ is a v2 addon](https://github.com/emberjs/data/commit/1f965a932d907c841ca9629b3788790278ab9ae4), which requires ember-auto-import v2 and ember-cp-validations doesn't list that as a dependency yet.

If I add ember-auto-import v2 to the dependency list of ember-cp-validations the code seems to work again.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.