adopted-ember-addons / adopted-ember-addons/ember-cp-validations

Composing validations stopped working in Ember 3.10

未關閉
#650 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
JavaScript
星號
439
分支
172
PR 合併指標
30 天內沒有已合併 PR

描述

### Environment

- Ember Version: 3.10
- Ember CLI Version: 3.8.0
- Ember CP Validations Version: 4.0.0-beta.9

### Steps to Reproduce

Before I updated to ember-source 3.10 (and to make it work, ember-cp-validations 4.0.0-beta.9), we had code like this that worked fine:

```js
const Validations = buildValidations(
{
...
}
);

export const SharedValidations = buildValidations(
{
...
}
);

export default Model.extend(Validations, SharedValidations, { });
```

After upgrading, this stopped working. I ended up just manually merging the validations and repeating the declarations, but wanted to let you know that this happened - it's also not really well documented, so not sure if that was even _supposed_ to work (although it was a quite handy feature...!).

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。