adopted-ember-addons / adopted-ember-addons/ember-cp-validations

`number`-Validator: `null`-Value validates differently for different number-ranges

Open
#643 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
439
Forks
172
PR merge metrics
No merged PRs in 30d

Description

### Environment

- Ember Version: 3.8.0
- Ember CLI Version: 3.8.1
- Ember CP Validations Version: 3.5.5

### Steps to Reproduce
Implement number-validator with options:
```javascript
{
allowString: true,
integer: true,
// allowNone: false,
gte: -1,
lte: 10
}
```

`null` or `undefined` validate this to true (because of `allowNone` defaults to `true`)
Positive number ranges like from 1 to 10 wont behave like that. Why is this the case?
Either `allowNone` works for every number range or it does never if there is a range provided.

Or am i missing something?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.