adopted-ember-addons / adopted-ember-addons/ember-cp-validations
Clarify `ignoreBlank` with `presence` validator
未關閉
- 主要語言
- JavaScript
- 星號
- 439
- 分支
- 172
- PR 合併指標
- 30 天內沒有已合併 PR
描述
### Environment
- Ember Version: 3.6.0
- Ember CLI Version: 3.6.0
- Ember CP Validations Version: 4.0.0-beta.5
I would have expected `ignoreBlank: true` to consider `''` as a valid value. But apparently it isn't. What was the original intention behind `ignoreBlank`? I was expecting something like rails, where `ignoreBlank` (`allowBlank: true`) to actually consider `''` value as a valid value.
Edit:
```js
// Shouldn't this line:
let _isPresent = ignoreBlank ? isPresent(v) : !isEmpty(v);
// be this short circuit instead?
if (ignoreBlank === true && v == '') {
return true;
}
```
貢獻指南
評估
這個 Issue 還沒有評估資料。