adopted-ember-addons / adopted-ember-addons/ember-collection
Updating NPM Dependencies to remove Deprecation Warnings
- Vorherrschende Sprache
- JavaScript
- Sterne
- 235
- Forks
- 81
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
While trying to update an app that uses this addon to v3.0.0 I ran into this deprecation:
An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from:
This needs to be fixed so that projects using this addon can upgrade to v3.0.0.
This should fix it:
Upgrade the version checker: ember-cli/ember-cli-version-checker#48
In the current release of this addon 1.0.0-alpha.8 it is using a few addons that need to be updated for this deprecation to go away. These are:
1. [Ember CLI Deploy GHPages](https://github.com/VerdigrisTech/ember-cli-deploy-ghpages)
1. [Layout Bin Packer](https://github.com/stefanpenner/layout-bin-packer)
About Ember CLI Deploy GHPages, I made a PR to them to fix this and updated the addon to Ember v2.18.2: https://github.com/VerdigrisTech/ember-cli-deploy-ghpages/pull/8
About Layout Bin Packer, this has been fixed in master but a new release needs to be put out:
https://github.com/stefanpenner/layout-bin-packer/issues/29
Is Ember CLI Deploy GHPages still needed by this project? Currently I don't think there is a GHPage branch that works.
If not I can finish my branch and create a PR:
https://github.com/Alonski/ember-collection/tree/update-dependencies
Also last thing... I removed Bower as a dependency. Don't think it is needed anymore.
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.