adonisjs / adonisjs/ace

ace is slow to exit when --hmr is used

Open
#167 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
412
Forks
39
Avg merge
4h 13m
Merged PRs (30d)
2

Description

Package version

@adonisjs/ace@14.1.0

Describe the bug

When I run node ace serve then type Ctrl-C to stop it, it quits immediately. When using node ace serve --hmr then it takes about 30-45 seconds to quit. Trying Ctrl-C many times doesn't exit any sooner.

I am using OSX Sequoia.

Reproduction repo

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with node ace serve and node ace serve --hmr, then trace the HMR shutdown path used after Ctrl-C. Compare the two exit behaviors and verify that the HMR command exits promptly after the fix.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.