adobe / adobe/xdm

Snake case used in enumerations on paymentItem

Open
#763 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
266
Forks
380
Avg merge
5d 8h
Merged PRs (30d)
9

Description

## What are the schemas that are affected by the issue
https://ns.adobe.com/xdm/data/paymentitem

In the enumeration for paymentType, snake-case is used for "credit_card", "debit_card", "gift-card", and others.

Is this desirable?

**Example below:**

"xdm:paymentType": {
"title": "Payment Type",
"type": "string",
"description": "The method of payment for this order. Enumerated, custom values allowed.",
"default": "other",
"meta:enum": {
"cash": "Cash",
"credit_card": "Credit Card",
"debit_card": "Debit Card",
"gift_card": "Gift Card",
"check": "Check",
"paypal": "PayPal",
"wire_transfer": "Wire Transfer",
"credit_card_reference": "Credit Card Reference Transaction",
"other": "Other"
}
},

Contributor guide

Open the contributing guide

Research direction

Start with the paymentItem schema at the linked Adobe XDM URL and inspect the paymentType enumeration values shown in the issue. Determine whether the naming convention should change and identify all affected values; done requires a documented decision and consistent schema updates if the convention is changed.

Written by the indexing model from the issue text.

Assessment

Domain
data
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.