repo:createdDate vs repo:createDate
- Dominant language
- JavaScript
- Stars
- 266
- Forks
- 380
- Avg merge
- 5d 8h
- Merged PRs (30d)
- 9
Description
Asked via email to Grp-XDM-API-WGs 10 May 2018:
There appears to be a discrepancy between the following:
- https://github.com/adobe/xdm/blob/master/schemas/external/repo/common.schema.json has “repo:createDate” (‘create’, not ‘created’).
- https://github.com/adobe/xdm/blob/master/schemas/external/repo/asset.schema.json has “repo:createdDate” (‘created’, not ‘create’), as do 5 other schema files and 14 example files in the schemas directory.
May I assume that common.schema.json is in error and that “repo:createdDate” is the correct property name?
NOTE: Leonard Rosenthol commented via email (before this issue was created) that he thinks that "repo:createDate" would be the correct one "since it is based on XMP". I was not aware that the repository metadata concepts were specifically based on XMP.
Whichever direction this goes, I recommend that the tense of both the "create" and "modify" metadata be aligned. (In other words, I recommend that we either choose "repo:createDate" and "repo:lastModifyDate" or choose "repo:createdDate" and "repo:lastModifiedDate". (Choosing the later would clearly require the least change to existing schemas.)
Current situation, looking only in the 'schemas' directory:
- repo:createDate: Found only in external/repo/common.schema.json
- repo:createdDate: Found in assets/asset.schema.json, assets/image.schema.json, assets/video.schema.json, content/componentized-page.schema.json, external/repo/asset.schema.json, and external/repo/directory.schema.json, and 14 example files.
- repo:lastModifyDate: Not found
- repo:lastModifiedDate: Found in assets/asset.schema.json, assets/image.schema.json, assets/video.schema.json, content/componentized-page.schema.json, external/repo/asset.schema.json, external/repo/common.schema.json, and external/repo/directory.schema.json, and 14 example files.
For comparison:
- xmp:createDate: Found in assets/asset.schema.json and 5 example files.
- xmp:modifyDate: Found in assets/asset.schema.json and 5 example files.
Contributor guide
Research direction
Compare schemas/external/repo/common.schema.json with the listed asset, directory, image, video, and componentized-page schemas and the 14 examples. Read the 16-comment thread and confirm the naming decision with a maintainer before editing. Done means the chosen create/modify naming is used consistently across the schemas and examples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- json
- Domain
- data
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100