adobe / adobe/svg-native-viewer

namespace for Qt port?

Open
#55 7 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
C++
Stars
164
Forks
42
PR merge metrics
No merged PRs in 30d

Description

I've written Qt4 port before, and now testing to use the source for Qt5 port.

Should I use different namespaces for Qt4 port and Qt5 port, like SVGNative::Qt4SvgRenderer and SVGNative::Qt5SvgRenderer? In my understanding, linking both of Qt4 and Qt5 to single library or binary is not recommended usage (I think it's almost impossible). So, even if I separate Qt4 and Qt5 into different namespaces, libSVGNativeViewer cannot be built well. There might be some plugin technique to link Qt4 only or Qt5 only in run-time. But I'm afraid it's overkilling.

I would propose SVGNative::QtSvgRenderer style naming, but if anybody prefers the versioned namespaces (even if the single version is available), please let me know.

Contributor guide

Open the contributing guide

Research direction

Start by reading the existing Qt4 port and the source planned for the Qt5 port, then review the discussion about SVGNative::QtSvgRenderer versus versioned namespaces. Done means recording an agreed namespace strategy that accounts for libSVGNativeViewer build and linking constraints.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.