adobe / adobe/spectrum-web-components
[Bug]: Button.disabled no longer defined
- Dominant language
- TypeScript
- Stars
- 1.5k
- Forks
- 262
- Avg merge
- 3d 10h
- Merged PRs (30d)
- 68
Description
### Code of conduct
- [x] I agree to follow this project's code of conduct.
### Impacted component(s)
Button
### Library version
@spectrum-web-components/button@1.7.0
### Expected behavior
Button.disabled should be defined as a boolean in typescript
### Actual behavior
Property 'disabled' does not exist on type 'Button'.ts(2339)
### Screenshots
### What browsers are you seeing the problem in?
_No response_
### How can we reproduce this issue?
access the Button.disabled property in TypeScript code.
### Sample code or abstract reproduction which illustrates the problem
private async onRegisterAsync(evt:Event){
const button = evt.currentTarget as unknown as Button;
try{
button.disabled = true;
### Severity
SEV 3
### Logs taken while reproducing problem
_No response_
### Would you like to track this issue in Jira?
- [x] Yes, please tell me the ticket number!
Contributor guide
Research direction
Start at the Button component's TypeScript definition and reproduce the shown Button.disabled assignment. Done when TypeScript exposes disabled as a boolean and the relevant project type checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100