adobe / adobe/spectrum-web-components
[Bug]: sp-button mod tokens blocked
- Dominant language
- TypeScript
- Stars
- 1.5k
- Forks
- 262
- Avg merge
- 3d 10h
- Merged PRs (30d)
- 68
Description
### Code of conduct
- [x] I agree to follow this project's code of conduct.
### Impacted component(s)
sp-button
### Expected behavior
To be able to use any --mod-* css tokens to override needed properties.
### Actual behavior
packages/button/src/button-overrides.css uses `--mod-*` tokens instead of `--spectrum-*` to override different variants of the button. Please see required patch to fix the issue:
https://github.com/adobe/spectrum-web-components/commit/7a47013c6056725f66e0a785992c472f9787537a
please note there is a typo for `--mspectrumod-button-background-color-down`, which should be `--spectrum-button-background-color-down`
### Screenshots
### What browsers are you seeing the problem in?
_No response_
### How can we reproduce this issue?
1. Go to https://opensource.adobe.com/spectrum-web-components/storybook/index.html?path=/story/button-group-sizes--m
### Sample code or abstract reproduction which illustrates the problem
_No response_
### Severity
SEV 1
### Logs taken while reproducing problem
_No response_
Contributor guide
Research direction
Open packages/button/src/button-overrides.css and compare its --mod-* overrides with the required patch in commit 7a47013c6056725f66e0a785992c472f9787537a. Use the button-group-sizes Storybook reproduction to verify the overrides, and confirm the typo is corrected to --spectrum-button-background-color-down.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100