adobe / adobe/spectrum-web-components
[Bug]: TabsOverflow size does not affect tabs size
- Dominant language
- TypeScript
- Stars
- 1.5k
- Forks
- 262
- Avg merge
- 3d 10h
- Merged PRs (30d)
- 68
Description
### Code of conduct
- [x] I agree to follow this project's code of conduct.
### Impacted component(s)
sp-tabs-overflow
### Expected behavior
Setting the size on sp-tabs-overflow should change the size of its slotted sp-tabs.
Although not explicitly documented in the [Tabs Overflow API](https://opensource.adobe.com/spectrum-web-components/components/tabs-overflow/api/), the TabsOverflow component does [include the SizedMixin](https://github.com/adobe/spectrum-web-components/blob/main/packages/tabs/src/TabsOverflow.ts#L43). There are also [stories](https://opensource.adobe.com/spectrum-web-components/storybook/index.html?path=/story/tabs-overflow-sizes--m&globals=system:express) for TabsOverflow sizes, indicating an intention of a functional size API.
### Actual behavior
Setting the size on sp-tabs-overflow does not affect the size of sp-tabs.
### Screenshots
_No response_
### What browsers are you seeing the problem in?
Microsoft Edge, Chrome, Safari, Firefox
### How can we reproduce this issue?
1. Go to https://studio.webcomponents.dev/edit/Lug2VHrYmBmjUZDzwFJf/src/index.ts?p=stories
2. Set the size of sp-tabs-overflow to "s" or "l"
3. Observe how the tabs don't change sizes
### Sample code or abstract reproduction which illustrates the problem
_No response_
### Severity
None
### Logs taken while reproducing problem
_No response_
Contributor guide
Research direction
Start with packages/tabs/src/TabsOverflow.ts and review how it includes SizedMixin and handles the slotted sp-tabs elements. Reproduce the issue using the linked Studio example or the TabsOverflow size stories, then verify that setting sp-tabs-overflow to "s" or "l" changes the slotted tabs' size.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100