adobe / adobe/spectrum-web-components

Make TabsOverflow more extensible

Open
#5,211 1 comment 0 reactions 0 assignees View on GitHub
Component:Tabs Feature SEV missing
Dominant language
TypeScript
Stars
1.5k
Forks
262
Avg merge
3d 10h
Merged PRs (30d)
68

Description

### Code of conduct

- [x] I agree to follow this project's code of conduct.

### Description of issue

We have a use case in Hz where we would like to extend from Tabs and TabsOverflow. TabsOverflow currently [queries for sp-tabs in its slot](https://github.com/adobe/spectrum-web-components/blob/main/packages/tabs/src/TabsOverflow.ts#L66) and uses that as its scrollContent, but we would like to query for other elements to use as the scroll content. One idea is to create a protected getter for scrollContent so child classes can override it.

Contributor guide

Open the contributing guide

Research direction

Start in packages/tabs/src/TabsOverflow.ts, especially the query for sp-tabs around line 66, and inspect how scrollContent is derived and used. Determine the smallest extensibility point that lets subclasses provide different scroll content; done means a child class can override that behavior without changing the existing TabsOverflow use case.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.