adobe / adobe/spectrum-web-components

[Feat]: --mod-* tokens for `sp-tabs-overflow` shadow color

Open
#4,993 1 comment 0 reactions 0 assignees View on GitHub
Component:Tabs Feature Spectrum CSS
Dominant language
TypeScript
Stars
1.5k
Forks
262
Avg merge
3d 10h
Merged PRs (30d)
68

Description

### Code of conduct

- [X] I agree to follow this project's code of conduct.

### Impacted component(s)

sp-tabs-overflow

### Description of the requested feature

sp-tabs-overflow doesn't have mod token to override the -sp-tabs-overflow-shadow-color , sp-tabs-overflow-next-button-left and sp-tabs-overflow-next-button-right for left and right button. Can it be added in the future? The reason is that I'm adding overflow tabs to the Properties Inspector, which has a background color of spectrum-gray-50, while the button shadow uses -spectrum-gray-100

### Mockups or screenshots

![Screenshot 2024-12-13 at 16 21 21](https://github.com/user-attachments/assets/036db84d-53a8-48bf-9c51-fb208e795f5e)

### Implementation notes or ideas

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the sp-tabs-overflow component implementation, which is the entry point named in the issue, and trace its shadow color and next-button styling. Compare the existing token patterns there, then confirm that the left and right button shadows can be overridden for the Properties Inspector background without changing the default appearance.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.