adobe / adobe/spectrum-web-components

[Feat]: Support for Brightness and Alpha channels in sp-color-slider

Open
#2,781 3 comments 0 reactions 0 assignees View on GitHub
Component:Color slider Feature Research
Dominant language
TypeScript
Stars
1.5k
Forks
262
Avg merge
3d 10h
Merged PRs (30d)
68

Description

### Code of conduct

- [X] I agree to follow this project's code of conduct.

### Impacted component(s)

sp-color-slider

### Description of the requested feature

Need to use the brightness and alpha sliders in Color Picker for my project.

Currently, we're using React Spectrum's ColorSlider and we're encountering an issue where when the slider is wrapped in an overlay-trigger and sp-popover to display the contents inside. If we press and hold on the color slider and drag it outside the popover, the popover gets closed and it doesn't happen if we use sp-color-picker.

### Mockups or screenshots

Screenshot 2022-12-06 at 12 43 21 AM

### Implementation notes or ideas

Can follow React Spectrum's component ColorSlider's implementation.

Contributor guide

Open the contributing guide

Research direction

Start by locating the sp-color-slider component and compare its implementation with React Spectrum's ColorSlider. Verify the requested brightness and alpha slider behavior, including dragging beyond an sp-popover without closing it; done means both channels are supported and the reported interaction works.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.