adobe / adobe/spacecat-audit-worker

Audits Should Not Follow URL Outside Of Domain

Open
#185 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
14
Forks
15
Avg merge
1d 21m
Merged PRs (30d)
58

Description

Currently audits follow the baseURL to its final URL even if outside of the site's (www?.) domain. This leads to situations where instead of the site an external site, e.g. an authentication provider, is audited. The URL resolver should return an error if we get outside the site's domain.

Contributor guide

Open the contributing guide

Research direction

Locate the URL resolver used when audits follow baseURL, then trace how it determines the site's (www?.) domain and handles redirects. Reproduce a redirect to an external authentication provider and verify that the resolver returns an error instead of auditing the external site.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.