adobe / adobe/react-spectrum

Package doesn't use "use client" whenever possible

Open
#9,701 5 comments 1 reaction 0 assignees View on GitHub
Dominant language
TypeScript
Stars
15.9k
Forks
1.6k
Avg merge
3d 9m
Merged PRs (30d)
59

Description

### Provide a general summary of the issue here

When using this package with React Server Components, it fails because code uses `createContext`

### 🤔 Expected Behavior?

The app to run well

### 😯 Current Behavior

The application crashes with following error:

```
17:10:41 [vite] Internal server error: (0 , $670gB$react).createContext is not a function
at eval (/home/alien/sites/obelisk-2/node_modules/.pnpm/@react-aria+ssr@3.9.10_react@19.2.4/node_modules/@react-aria/ssr/dist/SSRProvider.mjs?v=cbd4e01d:32:74)
at ESModulesEvaluator.runInlinedModule (file:///home/alien/sites/obelisk-2/node_modules/.pnpm/vite@7.3.1_@types+node@22.19.11_jiti@2.6.1_lightningcss@1.31.1_terser@5.46.0_tsx@4.21.0_yaml@2.8.2/node_modules/vite/dist/node/module-runner.js:913:3)
at ModuleRunner.directRequest (file:///home/alien/sites/obelisk-2/node_modules/.pnpm/vite@7.3.1_@types+node@22.19.11_jiti@2.6.1_lightningcss@1.31.1_terser@5.46.0_tsx@4.21.0_yaml@2.8.2/node_modules/vite/dist/node/module-runner.js:1146:59)
at ModuleRunner.cachedRequest (file:///home/alien/sites/obelisk-2/node_modules/.pnpm/vite@7.3.1_@types+node@22.19.11_jiti@2.6.1_lightningcss@1.31.1_terser@5.46.0_tsx@4.21.0_yaml@2.8.2/node_modules/vite/dist/node/module-runner.js:1053:73)
at eval (/home/alien/sites/obelisk-2/node_modules/.pnpm/@react-aria+ssr@3.9.10_react@19.2.4/node_modules/@react-aria/ssr/dist/import.mjs?v=cbd4e01d:6:31)
at ESModulesEvaluator.runInlinedModule (file:///home/alien/sites/obelisk-2/node_modules/.pnpm/vite@7.3.1_@types+node@22.19.11_jiti@2.6.1_lightningcss@1.31.1_terser@5.46.0_tsx@4.21.0_yaml@2.8.2/node_modules/vite/dist/node/module-runner.js:913:3)
at ModuleRunner.directRequest (file:///home/alien/sites/obelisk-2/node_modules/.pnpm/vite@7.3.1_@types+node@22.19.11_jiti@2.6.1_lightningcss@1.31.1_terser@5.46.0_tsx@4.21.0_yaml@2.8.2/node_modules/vite/dist/node/module-runner.js:1146:59)
at ModuleRunner.cachedRequest (file:///home/alien/sites/obelisk-2/node_modules/.pnpm/vite@7.3.1_@types+node@22.19.11_jiti@2.6.1_lightningcss@1.31.1_terser@5.46.0_tsx@4.21.0_yaml@2.8.2/node_modules/vite/dist/node/module-runner.js:1053:73)
at eval (/home/alien/sites/obelisk-2/node_modules/.pnpm/@react-aria+utils@3.33.0_react-dom@19.2.4_react@19.2.4__react@19.2.4/node_modules/@react-aria/utils/dist/useId.mjs?v=cbd4e01d:10:31)
at ESModulesEvaluator.runInlinedModule (file:///home/alien/sites/obelisk-2/node_modules/.pnpm/vite@7.3.1_@types+node@22.19.11_jiti@2.6.1_lightningcss@1.31.1_terser@5.46.0_tsx@4.21.0_yaml@2.8.2/node_modules/vite/dist/node/module-runner.js:913:3) (x2)
```

### 💁 Possible Solution

My current patch just adds "use client" to /home/alien/sites/obelisk-2/packages/application/node_modules/@react-spectrum/s2/dist/module.mjs but it may be more desirable to add it to the different files which import `createContext` (e.g. /home/alien/sites/obelisk-2/packages/application/node_modules/@react-spectrum/s2/dist/Accordion.mjs)

### 🔦 Context

_No response_

### 🖥️ Steps to Reproduce

Just run the app in vite with RSC plugin

### Version

1.1.0

### What browsers are you seeing the problem on?

Firefox

### If other, please specify.

_No response_

### What operating system are you using?

Linux

### 🧢 Your Company/Team

_No response_

### 🕷 Tracking Issue

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.