adobe / adobe/react-spectrum

The useOverlayPosition fails to correctly handle trigger targets with a 1px border

Open
#8,857 2 comments 0 reactions 0 assignees View on GitHub
Overlay Positioning
Dominant language
TypeScript
Stars
15.9k
Forks
1.6k
Avg merge
3d 9m
Merged PRs (30d)
59

Description

### Provide a general summary of the issue here

useOverlayPosition fails to correctly handle trigger targets with a 1px border. When the trigger button has a 1px border and the browser or screen is scaled to 150% or 110%, the border size becomes 0.9px or 0.8px respectively. At this point, useOverlayPosition appears unable to perform calculations properly.
Image

Image

### 🤔 Expected Behavior?

can normal diaplay border 1px

### 😯 Current Behavior

can not normal display

### 💁 Possible Solution

_No response_

### 🔦 Context

_No response_

### 🖥️ Steps to Reproduce

Set trigger button border 1px and offset = 0
https://stackblitz.com/edit/vitejs-vite-h2as2nzi?file=src%2FApp.tsx

### Version

latest

### What browsers are you seeing the problem on?

Chrome

### If other, please specify.

_No response_

### What operating system are you using?

macos

### 🧢 Your Company/Team

_No response_

### 🕷 Tracking Issue

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.