adobe / adobe/react-spectrum

No way to define keyframes for animation using style macros.

Open
#8,690 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
15.9k
Forks
1.6k
Avg merge
3d 9m
Merged PRs (30d)
59

Description

### Provide a general summary of the issue here

If we have to use animation we can't define keyframes using style macros. There is already a utility for this in style-macro.ts but its not exported.

https://github.com/adobe/react-spectrum/blob/155e361c6e2910c0b087ccba7cc61541fb50b0a7/packages/%40react-spectrum/s2/src/ProgressCircle.tsx#L17

### 🤔 Expected Behavior?

We should be able to define keyframes.

### 😯 Current Behavior

We can't define keyframes, as its not being exported from "@react-spectrum/s2/style".

### 💁 Possible Solution

Patch it or use regular CSS.

### 🔦 Context

_No response_

### 🖥️ Steps to Reproduce

import { keyframes } from "@react-spectrum/s2/style"; // No such export.

No way to define keyframes.

### Version

0.10.0

### What browsers are you seeing the problem on?

Chrome

### If other, please specify.

All

### What operating system are you using?

Windows

### 🧢 Your Company/Team

Adobe/Connect

### 🕷 Tracking Issue

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.