adobe / adobe/react-spectrum

Table: Duplicate item id causes infinite collection and out of memory crash

Open
#8,033 7 comments 2 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
15.9k
Forks
1.6k
Avg merge
3d 9m
Merged PRs (30d)
59

Description

### Provide a general summary of the issue here

After a recent react-aria upgrade we started seeing our Node servers tip over due to running out of memory. We managed to track the cause to be how we were constructing rows in our RAC based Table component.

Specifically, two or more rows sharing a single `id` when set via props on the Row element is where we saw the problem.

### 🤔 Expected Behavior?

Maybe we should warn in this case? Or ignore subsequent items with conflicting keys?

### 😯 Current Behavior

Page/app crashes once the array grows too large.

### 💁 Possible Solution

_No response_

### 🔦 Context

_No response_

### 🖥️ Steps to Reproduce

https://codesandbox.io/p/sandbox/winter-moon-szxxyj

### Version

react-aria-components@1.7.1

### What browsers are you seeing the problem on?

Chrome

### If other, please specify.

Also in Node during SSR

### What operating system are you using?

macos

### 🧢 Your Company/Team

_No response_

### 🕷 Tracking Issue

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.