Allow Modal to pass a dismiss label prop to DismissButton to override the default
- Dominant language
- TypeScript
- Stars
- 15.9k
- Forks
- 1.6k
- Avg merge
- 3d 9m
- Merged PRs (30d)
- 59
Description
### Provide a general summary of the feature here
In Modal -
https://github.com/adobe/react-spectrum/blob/main/packages/react-aria-components/src/Modal.tsx#L217
There is no way to pass a dismiss label to override the default. It is already supported by DismissButton.
### 💁 Possible Solution
Would you want Modal to take dismiss-aria-label ? I suppose aria-label on a Modal shouldn't be the text to dismiss?
### 🔦 Context
We have multiple ways to cancel/dismiss a dialog and for accessibility reasons I'd like them to have the same label. We also support some language variants you don't.
### 💻 Examples
_No response_
### 🧢 Your Company/Team
Saxo Bank
### 🕷 Tracking Issue
_No response_
Contributor guide
Assessment
This issue has not been assessed yet.