adobe / adobe/react-spectrum

[RAC] App freezes when mounting disabled table rows after selection

Open
#7,586 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
15.9k
Forks
1.6k
Avg merge
3d 9m
Merged PRs (30d)
59

Description

### Provide a general summary of the issue here

The app freezes completely when swapping table rows by disabled ones with different `key`.

### 🤔 Expected Behavior?

The app should not freeze.

### 😯 Current Behavior

The app freezes.

### 💁 Possible Solution

_No response_

### 🔦 Context

_No response_

### 🖥️ Steps to Reproduce

https://codesandbox.io/p/sandbox/fervent-architecture-6g96p6

1. Select 1 or more rows
- You **must not** select the 1st row only
- Ensure the blue focus outline appears on the row (it sometimes does not in Chromium-based browsers likely due to the iframe, native `:focus` has same issues)
2. Click "Toggle" button to swap out rows
3. App freezes

Remove `isDisabled` from all loading rows in code and try again. It does not freeze anymore.

https://github.com/user-attachments/assets/20972550-967d-4e75-b48a-f8ffb4f9601c

### Version

1.5.0

### What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

### If other, please specify.

_No response_

### What operating system are you using?

macOS

### 🧢 Your Company/Team

_No response_

### 🕷 Tracking Issue

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.