adobe / adobe/react-spectrum

Popover entry animations do not fire when shouldUpdatePosition=false

Open
#6,174 1 comment 1 reaction 0 assignees View on GitHub
Overlay Positioning Overlays
Dominant language
TypeScript
Stars
15.9k
Forks
1.6k
Avg merge
3d 9m
Merged PRs (30d)
59

Description

### Provide a general summary of the issue here

When `shouldUpdatePosition` is set to `false`, the popover does not trigger `data-entering`

### 🤔 Expected Behavior?

it should trigger data-entering

### 😯 Current Behavior

it does not trigger data entering

### 💁 Possible Solution

I assume because `shouldUpdatePosition` is `false` that step of rendering is skipped entirely

### 🔦 Context

_No response_

### 🖥️ Steps to Reproduce

https://codesandbox.io/p/sandbox/naughty-sanne-95mcvz?file=%2Fsrc%2FApp.js%3A10%2C15

### Version

3.31.0

### What browsers are you seeing the problem on?

Firefox, Chrome, Safari

### If other, please specify.

_No response_

### What operating system are you using?

n/a

### 🧢 Your Company/Team

_No response_

### 🕷 Tracking Issue

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.