adobe / adobe/react-spectrum

[RAC] ComboBox does not set data-focus-visible or data-hovered attributes

Open
#5,974 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
15.9k
Forks
1.6k
Avg merge
3d 9m
Merged PRs (30d)
59

Description

### Provide a general summary of the issue here

RAC `ComboBox` does not set ComboBox does not set `data-focus-visible` or `data-hovered` attributes. This makes it difficult to set styling on keyboard focus and hover. I can work around it using the hover state of the button and input. Using the `data-focused` attribute instead of `data-focus-visible` can be an option, but only if you don't require distinct states for styling.

### 🤔 Expected Behavior?

`ComboBox` sets the `data-focus-visible` and `data-hovered` attributes when appropriate.

### 😯 Current Behavior

`ComboBox` does not set the `data-focus-visible` or `data-hovered` attributes.

### 💁 Possible Solution

_No response_

### 🔦 Context

_No response_

### 🖥️ Steps to Reproduce

https://react-spectrum.adobe.com/react-aria/ComboBox.html#example

### Version

RAC 1.1.1

### What browsers are you seeing the problem on?

Chrome

### If other, please specify.

_No response_

### What operating system are you using?

Mac OS

### 🧢 Your Company/Team

_No response_

### 🕷 Tracking Issue

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.