adobe / adobe/react-spectrum

Row renderProps never called for focus

Open
#5,299 0 comments 0 reactions 0 assignees View on GitHub
bug RAC
Dominant language
TypeScript
Stars
15.9k
Forks
1.6k
Avg merge
3d 9m
Merged PRs (30d)
59

Description

### Provide a general summary of the issue here

See commented out test here https://github.com/adobe/react-spectrum/pull/5265/files#diff-a13c00134586126ed1d1f02bf6549ac11dd15c3e8b300a7dc89d6829992356f4R649

We aren't calling the child function with the updated renderProps when a row is hovered

### 🤔 Expected Behavior?

Row's child function is called again with the updated renderProps which match the data-* attributes

### 😯 Current Behavior

Does not update

### 💁 Possible Solution

_No response_

### 🔦 Context

_No response_

### 🖥️ Steps to Reproduce

Uncomment code, run test. Alternatively, open storybook from the same PR and add a console.log, it won't be called after initial render if you tab to the table and navigate around.

### Version

latest

### What browsers are you seeing the problem on?

Chrome

### If other, please specify.

_No response_

### What operating system are you using?

MacOS

### 🧢 Your Company/Team

_No response_

### 🕷 Tracking Issue

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the commented-out test linked in pull request 5265 at the referenced diff, then inspect the row and table rendering path it exercises. Run the test and reproduce the issue by tabbing to the table and navigating rows; done means the child function is called with updated renderProps matching the data-* attributes.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.