adobe / adobe/react-spectrum

Missing `updatePosition` from `usePopover` return value.

Open
#4,040 4 comments 3 reactions 0 assignees View on GitHub
Overlay Positioning Overlays
Dominant language
TypeScript
Stars
15.9k
Forks
1.6k
Avg merge
3d 9m
Merged PRs (30d)
59

Description

# 🐛 Bug Report

`usePopover` is meant to replace the low-lever `useOverlayPosition` but because of a missing return value it can't in some cases.

## 🤔 Expected Behavior

`updatePosition` should be returned from `usePopover`.

## 😯 Current Behavior

`updatePosition` from `useOverlayPosition` which is useful for many scenarios, is not returned by `usePopover`.

## 💁 Possible Solution

There's an old, [open PR](https://github.com/adobe/react-spectrum/pull/3872).

## 🔦 Context

Was looking at replacing our usage of low-level hooks which have been replaced by `usePopover`.

## 💻 Code Sample

N/A

## 🌍 Your Environment

N/A

## 🧢 Your Company/Team

N/A

## 🕷 Tracking Issue (optional)

N/A

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.