adobe / adobe/react-spectrum

onLoadMore is called when ComboBox tray is opened

Open
#2,607 0 comments 0 reactions 0 assignees View on GitHub
bug ComboBox
Dominant language
TypeScript
Stars
15.9k
Forks
1.6k
Avg merge
3d 9m
Merged PRs (30d)
59

Description

# 🐛 Bug Report

Related to https://github.com/adobe/react-spectrum/issues/2365, caught during subsequent testing. Looks like the fix provided doesn't quite work for the ComboBox tray case, onLoadMore is still called every time the tray opens regardless of the number of items that are already loaded.

## 🤔 Expected Behavior

onLoadMore shouldn't be called when the combobox tray opens and there are enough items loaded to populate the tray height * 1.5

## 😯 Current Behavior

onLoadMore is always called on ComboBox tray open.

## 🌍 Your Environment

| Software | Version(s) |
| ---------------- | ---------- |
| react-spectrum |. 3.15
| Browser |
| Operating System |

## 🧢 Your Company/Team

RSP

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.