adobe / adobe/react-spectrum

Combobox does not close on ModalOverlay click when menuTrigger=focus

Open
#10,074 1 comment 1 reaction 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
15.9k
Forks
1.6k
Avg merge
3d 9m
Merged PRs (30d)
59

Description

### Provide a general summary of the issue here

When combobox `menuTrigger` is set to `focus`, clicking the ModalOverlay does not close an open combobox.

```jsx

Item 1
Item 2

```

This was working correctly in react-aria-components version `1.16.0`, but after upgrading to `1.17.0`, clicking the modal overlay no longer closes the combobox popover.

The issue seems specific to menuTrigger="focus" since menuTrigger="input" and menuTrigger="manual" still working correctly.

### 🤔 Expected Behavior?

The combobox popover should close when the modal overlay is clicked.

### 😯 Current Behavior

The combobox popover remains open after clicking the modal overlay.

### 💁 Possible Solution

_No response_

### 🔦 Context

_No response_

### 🖥️ Steps to Reproduce

https://stackblitz.com/edit/c3rm1h73-dyetugob?file=src%2FExample.tsx

### Version

react-aria-components@1.17.0

### What browsers are you seeing the problem on?

Chrome

### If other, please specify.

_No response_

### What operating system are you using?

macos 26.4.1

### 🧢 Your Company/Team

_No response_

### 🕷 Tracking Issue

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the linked StackBlitz reproduction and compare react-aria-components 1.17.0 with 1.16.0, focusing on the ComboBox behavior when menuTrigger="focus". Verify the existing input and manual triggers as controls; done means clicking the ModalOverlay closes the open combobox popover without regressing those triggers.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.