adobe / adobe/react-spectrum-charts

Inconsistent color on value labels

Open
#701 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
127
Forks
29
Avg merge
7d 2h
Merged PRs (30d)
21

Description

### Provide a general summary of the issue here

The color of value labels is being controlled with the `thresholdBarColor` control

### 🤔 Expected Behavior?

The label color should have it's own control or it should always stay black (as it does today when `labelPosition` is set to "side")

### 😯 Current Behavior

`thresholdBarColor` also effects the value label color, but only if the `labelPosition` is "top".

### 💁 Possible Solution

The label color should have it's own control or it should always stay black (as it does today when `labelPosition` is set to "side"). Always black is less flexible, but it will protect against in accessible text.

### 🔦 Context

_No response_

### 🖥️ Steps to Reproduce

Set `thresholdBarColor` to "True". Toggle `labelPosition` between "top" and "side".

### Version

yes

### What browsers are you seeing the problem on?

Chrome

### If other, please specify.

_No response_

### What operating system are you using?

MacOS Sequoia 15.7.3

### 🧢 Your Company/Team

_No response_

### 🕷 Tracking Issue

_No response_

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue by setting thresholdBarColor to "True" and toggling labelPosition between "top" and "side". Trace how those controls determine value-label color, then make the label color consistent or independently controlled while preserving accessible contrast; verify both label positions in Chrome.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.